Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split vehicle part wheel_caster into small and large variants #72089

Merged
merged 4 commits into from
Mar 3, 2024

Conversation

wormingdead
Copy link
Contributor

@wormingdead wormingdead commented Mar 1, 2024

Summary

Content "Split vehicle part wheel_caster into small and large variants"

Purpose of change

Caster wheels have been sort of pulling double duty being used for both indoor furniture such as office chairs as well as outdoor vehicles such as grocery carts, and causing issues with how dragging requirements are calculated. See also #65972.

Describe the solution

The proposed solution is splitting casters into 2 inch and 6 inch variants for indoor and outdoor use, respectively. Specifically, casters will be renamed to small casters and large casters will be introduced.

The vehicle part stat changes were basically compiled from comparing 2 inch casters to 6 inch casters on Amazon.com, though I'm not quite sure what units rolling resistance uses. The current value for casters (now small casters) is three times higher than any other wheel vehicle part. (Except for wheel_10, which was introduced in #36564 as another replacement for casters and probably just copied the value.)

I also changed a few vehicles to use the large casters, specifically:

  • Shopping Cart
  • Rolling Trash Can
  • Grocery Cart
  • Welding Cart

Describe alternatives you've considered

There's probably value in going over the wheel physics to make sure there that all the vehicle parts have correct stats, but I still think that it's better to have two separate parts instead of pretending shopping carts use the same wheels as office chairs.

Testing

Threw the JSON files in a Cata install and loaded a new world and checked the recipes and spawned in a Rolling Trash Can. Everything seemed to work.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` labels Mar 1, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Mar 1, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 1, 2024
@Maleclypse Maleclypse merged commit 63fdf33 into CleverRaven:master Mar 3, 2024
22 of 27 checks passed
@wormingdead wormingdead deleted the wheel-caster-split branch March 3, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants